fix: remove deprecated pip cache action #19552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Jan 2, 2024
.github/workflows/benchmark.yml
Outdated
| with: | ||
| python-version: 3.10.10 | ||
| cache: 'pip' | ||
| cache-dependency-path: 'requirements*.txt' |
There was a problem hiding this comment.
Examples always include **/ eg **/requirements*.txt
We probably don't need that?
There was a problem hiding this comment.
I wondered about that... we're super unlikely to add more requirements files but 🤷
I guess I can check if it affects the running speed and (how much could it after all) it it isn't slower then it helps the future traveller to have the wildcard
There was a problem hiding this comment.
yeah it depends on how deep the nested folders go since it is a mono repo, but likely it won't affect anything noticeable, your call :D
There was a problem hiding this comment.
yeah, no noticeable effect on speed so it doesn't hurt 😊
marandaneto
approved these changes
Jan 2, 2024
fuziontech
pushed a commit
that referenced
this pull request
Jan 4, 2024
* fix: remove deprecated pip cache action * with wildcard * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we use https://github.com/syphar/restore-pip-download-cache which was deprecated 9 months ago
let's switch to its recommendation of the default python action cache
we see the cache used on a second run